This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Add adjustFontSize event to ViewCommandHandlers module #3787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -24,6 +24,16 @@ | |||
| /*jslint vars: true, plusplus: true, devel: true, nomen: true, indent: 4, maxerr: 50 */ | |||
| /*global define, window, $ */ | |||
|
|
|||
| /** | |||
| * The ViewCommandHandlers object dispatches the following event(s): | |||
| * - adjustFontSize -- Triggered when the font size is adjusted via the | |||
There was a problem hiding this comment.
Naming nit: in general we name events like this by adding "change" to the end of the thing changing, so fontSizeChange would be a better name.
|
Looks fine aside from the name. Will merge once you fix that. |
|
@njx, event name changed to fontSizeChange. |
|
Looks good, merging. |
njx
pushed a commit
that referenced
this pull request
May 13, 2013
Add adjustFontSize event to ViewCommandHandlers module
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for me to complete my Brackets Column Ruler extension