Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Hacking scripts on Mac won't work if dev is a broken symlink #2895

Closed
jbalsas opened this issue Feb 16, 2013 · 2 comments
Closed

Hacking scripts on Mac won't work if dev is a broken symlink #2895

jbalsas opened this issue Feb 16, 2013 · 2 comments
Assignees
@gruehle
Labels
fix in progress Mac only
Milestone
sprint 21

Comments

@jbalsas
Copy link
Contributor

jbalsas commented Feb 16, 2013

While hacking on Brackets on MacOS, if you delete the current folder used as source, running the scripts setup_for_hacking or restore_installed_build won't work because the old dev symlink isn't removed.

Steps to reproduce

  1. Clone two different branches of brackets (Or the same one into two different folders)
  2. Run setup_for_hacking from the first one
  3. Remove the first folder
  4. Run setup_for_hacking or restore_installed_build from the second folder.

Expected
The dev symlink to point to the second folder or to get deleted

Result
The dev symlink remains unchanged
@jbalsas jbalsas mentioned this issue Feb 16, 2013
Merged
@ghost ghost assigned gruehle Feb 20, 2013
@pthiess
Copy link
Contributor

pthiess commented Feb 20, 2013

@gruehle

gruehle added a commit that referenced this issue Feb 20, 2013
@gruehle
Merge pull request #2896 from jbalsas/fix-2895
52da880 
Add check for broken symlinks to hacking scripts (#2895)
@gruehle
Copy link
Member

gruehle commented Feb 28, 2013

Fixed in #2896. Closing.

@gruehle gruehle closed this as completed Feb 28, 2013
@core-ai-bot core-ai-bot mentioned this issue Aug 29, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gruehle gruehle

Labels
fix in progress Mac only
Projects
None yet
Milestone
sprint 21
Development

No branches or pull requests
3 participants
@jbalsas @gruehle @pthiess