Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update play_time to explicitly send the default time format. Older aster... #14

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

vindir
Copy link
Member

@vindir vindir commented May 18, 2013

...isk versions won't handle dangling nil arguments.

…terisk versions won't handle dangling nil arguments.
@benlangfeld
Copy link
Member

For which versions of Asterisk does the old behaviour not work?

@benlangfeld
Copy link
Member

In Asterisk 1.8+ the default format will be used if no format is specified. I think it's better to not send the format (as opposed to sending '') rather than override a default here.

@vindir
Copy link
Member Author

vindir commented May 21, 2013

Hey Ben, the asterisk version in question is the default install on Rackspace's image of Ubuntu 12.04.

We could have the application to force a default on the timezone, but this error fails silently and it's on a pretty common distribution. If you'd rather not force a default still, is there some way we can track success/failure on sayunixtime calls to give some feedback to the user?

@bklang
Copy link
Member

bklang commented May 21, 2013

I agree with @benlangfeld about not supplying a default format. If the format isn't specified, we should simply not send the empty commas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants