Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add product placement and kijkwijzer metadata #817

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Add product placement and kijkwijzer metadata #817

merged 1 commit into from
Sep 28, 2020

Conversation

mediaminister
Copy link
Collaborator

@mediaminister mediaminister commented Sep 28, 2020 •
edited by dagwieers
Loading

This adds the kijkwijzer string to the mpaa Listitem infoLabel and adds PP and kijkwijzer string to the plot Listitem infoLabel.

This fixes #816

@mediaminister mediaminister added this to the v2.4.1 milestone Sep 28, 2020
@mediaminister mediaminister added the enhancement New feature or request label Sep 28, 2020
@mediaminister mediaminister mentioned this pull request Sep 28, 2020
Closed
@dagwieers
Copy link
Collaborator

In VTM GO we use a metadata field used for this IIRC.

@mediaminister
Copy link
Collaborator Author

Indeed, the mpaa field and this PR adds the kijkwijzer string to this field. Do I need to add product placement also?

@dagwieers
Copy link
Collaborator

Indeed, the mpaa field and this PR adds the kijkwijzer string to this field. Do I need to add product placement also?

Ah yes, it was the mpaa field ;-) I haven't tested it, but let's merge so I can test it together with the new library support.
I think our next release will become v2.5.0 packed with new features !

@dagwieers dagwieers merged commit 1e04361 into add-ons:master Sep 28, 2020
@dagwieers
Copy link
Collaborator

It is unfortunate my PR to add more metadata to the Information pane and studio icons to all views was never backported to Leia :-(
I patched my systeùs manually and it gives a much better user-experience IMO.

@mediaminister mediaminister deleted the guidelines branch January 21, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.4.1
Development

Successfully merging this pull request may close these issues.

Implement ageGroup and productPlacement support
2 participants
@mediaminister @dagwieers