Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend soon offline menu to seven days #796

Merged
merged 2 commits into from
Jul 28, 2020
Merged

Extend soon offline menu to seven days #796

merged 2 commits into from
Jul 28, 2020

Conversation

mediaminister
Copy link
Collaborator

@mediaminister mediaminister commented Jul 23, 2020 •
edited
Loading

This fixes #388

@mediaminister mediaminister added the enhancement New feature or request label Jul 23, 2020
@dagwieers
Copy link
Collaborator

I rebased this PR for testing.

dagwieers
dagwieers reviewed Jul 28, 2020
View reviewed changes
Copy link
Collaborator

@dagwieers dagwieers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion.

resources/lib/apihelper.py Outdated Show resolved Hide resolved
@dagwieers
Copy link
Collaborator

For me this works fine, and is probably good enough to fix #388

@dagwieers dagwieers added this to the v2.4.1 milestone Jul 28, 2020
@mediaminister mediaminister marked this pull request as ready for review July 28, 2020 14:08
@mediaminister
Copy link
Collaborator Author

I'll merge this.

@mediaminister mediaminister merged commit 2e2da49 into add-ons:master Jul 28, 2020
@mediaminister mediaminister deleted the soonoffline branch January 21, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagwieers dagwieers dagwieers left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.4.1
Development

Successfully merging this pull request may close these issues.

Show more than one day of "Soon offline"
2 participants
@mediaminister @dagwieers