Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New artwork #416

Merged
merged 2 commits into from
Aug 12, 2019
Merged

New artwork #416

merged 2 commits into from
Aug 12, 2019

Conversation

mediaminister
Copy link
Collaborator

This pull request includes:

  • new artwork
  • function to delete old artwork from cache on first run of 2.2.0 version

@dagwieers dagwieers added the enhancement New feature or request label Aug 12, 2019
@dagwieers dagwieers added this to the v2.2.0 milestone Aug 12, 2019
@dagwieers
Copy link
Collaborator

My only concern here was the move from a .jpg to a .png because the documentation specifically talks about it being fanart.jpg. But looking at what exists in the official repository:

[dag@moria xbmc-repo-plugins]$ grep '.jpg</fanart>' */addon.xml | wc -l
109
[dag@moria xbmc-repo-plugins]$ grep '.png</fanart>' */addon.xml | wc -l
4

So I think we're good :-)

@dagwieers dagwieers merged commit 4390d9f into add-ons:master Aug 12, 2019
@mediaminister
Copy link
Collaborator Author

kodi-addon-checker didn't complain and saving vector art in jpg format is completely insane.

@mediaminister mediaminister deleted the artwork branch August 21, 2019 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants