More cleanups to new routing interface #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR includes: - Reorganize the order of routes - Adding docstrings to all routes - Don't instantiate single-purpose objects - Don't import libraries that are usd infequently in vrtplayer.py - Remove test() function from addon.py for testing routing
dagwieers
force-pushed
the
routing-cleanup
branch
from
fa7a84c to
66996bb
Compare
|
I am going to merge this now (I haven't tested it in full myself as I cannot now), but I like to work on #305 and I need this merged to avoid conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes: