Replace Mock with xbmc library replacement #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagwieers
force-pushed
the
rewrite-unit-tests
branch
2 times, most recently
from
17ea51f to
a476147
Compare
This PR includes: - Implementation of xbmc libraries - New unit tests For testing the caching-functionality the use of Mock() became an even more complex issue. So this replaces a quite complex Mock() setup to mock kodiwrapper with an alternative implementation of the xbmc libraries. The benefit is that we don't have to fake every possible kodiwrapper functionality, but only the xbmc functionality that kodiwrapper is using. This means we are now also testing kodiwrapper to a greater extent.
dagwieers
force-pushed
the
rewrite-unit-tests
branch
from
a476147 to
69302df
Compare
dagwieers
added a commit
to dagwieers/plugin.video.vrt.nu
that referenced
this pull request
May 20, 2019
This PR includes: - Implementation of xbmc libraries - New unit tests For testing the caching-functionality the use of Mock() became an even more complex issue. So this replaces a quite complex Mock() setup to mock kodiwrapper with an alternative implementation of the xbmc libraries. The benefit is that we don't have to fake every possible kodiwrapper functionality, but only the xbmc functionality that kodiwrapper is using. This means we are now also testing kodiwrapper to a greater extent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For testing the caching-functionality the use of Mock() became an even
more complex issue. So this replaces a quite complex Mock() setup to
mock kodiwrapper with an alternative implementation of the xbmc
libraries.
The benefit is that we don't have to fake every possible kodiwrapper
functionality, but only the xbmc functionality that kodiwrapper is
using. This means we are now also testing kodiwrapper to a greater
extent.
This is split off from #258