Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit tests #198

Merged
merged 1 commit into from
May 11, 2019
Merged

Fix unit tests #198

merged 1 commit into from
May 11, 2019

Conversation

dagwieers
Copy link
Collaborator

@dagwieers dagwieers commented May 8, 2019 •
edited
Loading

This PR includes:

  • Add unit tests to pylint
  • Fix unit tests (even if they don't work as-is yet)
  • Run streamserviceests.py as part of unit tests (not by Travis)

@dagwieers dagwieers added the enhancement New feature or request label May 8, 2019
@dagwieers dagwieers added this to the v2.0.0 milestone May 8, 2019
@dagwieers dagwieers force-pushed the py-move branch 4 times, most recently from 9719e44 to 47b8d17 Compare May 8, 2019 17:11
@dagwieers
Copy link
Collaborator Author

@mediaminister @pietje666 Approved ?

@mediaminister
Copy link
Collaborator

mediaminister commented May 8, 2019 •
edited
Loading

No! I get an error: ImportError: No module named resources.lib.kodiwrappers

I don't think this can be merged: https://kodi.wiki/view/Add-on_structure#Directory_structure

@dagwieers
Copy link
Collaborator Author

dagwieers commented May 8, 2019 •
edited
Loading

Ok, I fixed that. May need a bit more thought, as it has the same impact as #187

@pietje666
Copy link
Collaborator

Code wise it looks good :)

@dagwieers dagwieers changed the title Move all python code to resources/lib/ WIP: Move all python code to resources/lib/ May 8, 2019
@mediaminister
Copy link
Collaborator

I still get the same error. ImportError: No module named resources.lib.kodiwrappers

@dagwieers
Copy link
Collaborator Author

@mediaminister Yup, this will require the same modifications as #187, so I think I am going to split off the unit test fixes, and drop this in favor of #187, which already has the required modifications (but not using the same path).

@dagwieers dagwieers changed the title WIP: Move all python code to resources/lib/ Fix unit tests May 11, 2019
@dagwieers dagwieers force-pushed the py-move branch 3 times, most recently from ffaa0f4 to 6a1b857 Compare May 11, 2019 01:09
@dagwieers
Fix unit tests
78525d1 
This PR includes:
- Add unit tests to pylint
- Fix unit tests
@dagwieers dagwieers merged commit 8bdd3cd into add-ons:master May 11, 2019
@dagwieers dagwieers modified the milestones: v2.0.0, v1.10.0 May 14, 2019
@dagwieers dagwieers added testing Related to automated testing and removed enhancement New feature or request labels Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
testing Related to automated testing
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dagwieers @mediaminister @pietje666