Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Movies and TV Series into the Kodi library #9

Merged
merged 8 commits into from
Nov 3, 2020

Conversation

michaelarnauts
Copy link
Contributor

@michaelarnauts michaelarnauts commented Sep 27, 2020

Allows to integrate the movies and tv series into Kodi. You have the option to configure the behaviour to export everything or only the items in "My List". This can be configured separately for movies and series. When switching from a full export to "My List", you need to run Library cleanup for the other items to be removed from your library.

When running a library cleanup, we take a snapshot of all ids's in the catalog (or in my list if you only export that) and check if they are in that list. This is a lot faster than using the API, and is also more correct compared with if we would use the cache.

There were quite some issues / wtf's:

  • I couldn't get the Library cleanup feature to work reliably when using "folder paths" like /library/tvshows/123456/, therefore, I'm using query parameters.
  • When adding a path to the library, even if you enter it without a trailing slash, when you edit, it will have a slash appended.
  • The routing library strips trailing slashes, but Kodi expects a trailing slash. This in combination with the previous line causes some headache.
  • There is no way to add sources programmatically, therefore, the best we can do is indicate the user to read the README, and add a shortcut to the right screen where he can add the sources.

More information on the implementation: xbmc/xbmc#13566 and xbmc/xbmc#14210

@michaelarnauts michaelarnauts added the enhancement New feature or request label Sep 27, 2020
@michaelarnauts michaelarnauts force-pushed the vod-integration branch 2 times, most recently from 98ba352 to e3c15ef Compare September 28, 2020 18:56
@michaelarnauts michaelarnauts changed the title Integrate Movie and TV Series into the Kodi library Integrate Movies and TV Series into the Kodi library Sep 28, 2020
resources/lib/modules/library.py Outdated Show resolved Hide resolved
resources/lib/modules/library.py Outdated Show resolved Hide resolved
resources/lib/modules/menu.py Show resolved Hide resolved
@michaelarnauts michaelarnauts marked this pull request as ready for review October 29, 2020 17:40
@michaelarnauts
Copy link
Contributor Author

I think this is as ready as it can be :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant