Add tests from node-semver #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreeve
reviewed
May 2, 2023
| @@ -67,6 +66,7 @@ public void MatchingPreReleaseWithIncludePrereleases(string rangeString, string | |||
| [InlineData("<1.3", "1.3.0-alpha.1")] | |||
| [InlineData("~1.2.3", "1.3.0-alpha.1")] | |||
| [InlineData("^0.2.3", "0.2.2-alpha")] | |||
| [InlineData("^0.2.3", "0.2.3-alpha")] | |||
There was a problem hiding this comment.
I think this change is correct, and matches the reasoning in npm/node-semver#409, but node-semver (version 7.5.0) actually treats this as satisfied. It looks like this is possibly a bug in node-semver though as this behaviour is inconsistent compared to versions with a major version number:
> semver.satisfies('0.2.3-alpha', '^0.2.3', {includePrerelease: true})
true
> semver.satisfies('1.2.3-alpha', '^1.2.3', {includePrerelease: true})
false
There was a problem hiding this comment.
I've raised npm/node-semver#557 for this, will hold off merging this for now and see if I get a response.
|
Apologies for the delay on this, I never heard back about the node-semver issue but this change looks correct to me so I'll merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this branch, some test fails but with #55, All tests passes.