Restart Django development server on Python file changes #229
Conversation
Force server reload when Python files are changed even if they are in templates or static directories. Fixes adamchainz#224
|
Hey @adamchainz, could you please take a look at it and give your feedback whenever you have some time? Thanks a lot! |
|
@imankulov @adamchainz I applied this patch locally and it worked great! Thank you so much! |
|
Good afternoon. Is there anything additoinal that needs to be done before this can be merged? |
|
I tried out this change with django-components, and it worked great for triggering the runserver reload. A problem I ran into was that the change triggers both the runserver and the browser refresh in the on_file_changed function. I believe the browser refresh is unnecessary because restarting the runserver already triggers a browser refresh. When I tested the change, sometimes the first refresh would happen before the runserver had fully restarted, and so I would get an 'unable to connect' error page. I changed the on_file_changed function to either trigger a runserver reload for .py files or a browser refresh for everything else, and now everything is working smoothly for me. |
|
@jesserankin can you share your updates? |
|
Sure, you can see my changes here: This was just a quick change I made to fix the issue I was having, but isn't polished. I'm happy to do some more work on it if it would help this PR to get merged. |
Force server reload when Python files are changed even if they are in
templates or static directories.
Fixes #224