Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEEP-208] provide creds dict with non empty strings #2901

Merged
merged 1 commit into from
Jul 12, 2024
Merged

[DEEP-208] provide creds dict with non empty strings #2901

merged 1 commit into from
Jul 12, 2024
+14 −14

Conversation

activesoull
Copy link
Contributor

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

@activesoull activesoull changed the title provide creds dict with non empty strings [DEEP-208] provide creds dict with non empty strings Jul 12, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Jul 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
deeplake/enterprise/convert_to_libdeeplake.py 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@activesoull activesoull merged commit a945190 into main Jul 12, 2024
8 of 10 checks passed
@activesoull activesoull deleted the creds_to_dict branch July 12, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvoxland-al nvoxland-al nvoxland-al approved these changes

@khustup2 khustup2 khustup2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@activesoull @khustup2 @nvoxland-al