Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BytePositionsEncoder fix #1516

Merged
merged 1 commit into from
Mar 1, 2022
Merged

BytePositionsEncoder fix #1516

merged 1 commit into from
Mar 1, 2022

Conversation

farizrahman4u
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #1516 (0ca32c1) into main (035fcd4) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1516      +/-   ##
==========================================
+ Coverage   92.31%   92.36%   +0.05%     
==========================================
  Files         189      189              
  Lines       16390    16415      +25     
==========================================
+ Hits        15130    15162      +32     
+ Misses       1260     1253       -7     
Flag Coverage Δ
unittests 92.36% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/api/tests/test_update_samples.py 100.00% <100.00%> (ø)
hub/core/meta/encode/base_encoder.py 96.74% <100.00%> (ø)
hub/core/lock.py 88.65% <0.00%> (-5.64%) ⬇️
hub/core/dataset/dataset.py 93.08% <0.00%> (-0.41%) ⬇️
hub/core/ipc.py 0.00% <0.00%> (ø)
hub/core/query/filter.py 87.79% <0.00%> (+0.04%) ⬆️
hub/core/compression.py 87.75% <0.00%> (+0.11%) ⬆️
hub/__init__.py 93.87% <0.00%> (+0.12%) ⬆️
hub/util/exceptions.py 80.74% <0.00%> (+0.33%) ⬆️
hub/tests/path_fixtures.py 90.69% <0.00%> (+0.46%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 035fcd4...0ca32c1. Read the comment docs.

@farizrahman4u farizrahman4u merged commit 402ebb6 into main Mar 1, 2022
@farizrahman4u farizrahman4u deleted the fr_bp_enc branch March 1, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants