-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AL-1589] Autocomplete and code highlighting #1453
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1453 +/- ##
==========================================
- Coverage 91.69% 91.16% -0.53%
==========================================
Files 179 181 +2
Lines 14910 14984 +74
==========================================
- Hits 13671 13660 -11
- Misses 1239 1324 +85
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
import hub | ||
|
||
|
||
def test_autcomplete(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please convert to and split into unit tests.
hub/core/query/autocomplete.py
Outdated
last_type = last_token["type"] | ||
last_string = last_token["string"] | ||
|
||
if last_type == "UNKNOWN": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have better structure for this ? Perhaps, Dict[Token, Func]
?
Or at least documentation of what is going on here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tough to review this currently, docstrings and comments are needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add more codecov, rest looks good.
🚀 🚀 Pull Request
Checklist:
coverage-rate
upChanges