Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tiling + pytorch #1427

Merged
merged 9 commits into from
Jan 12, 2022
Merged

Fix tiling + pytorch #1427

merged 9 commits into from
Jan 12, 2022

Conversation

AbhinavTuli
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

@codecov
Copy link

codecov bot commented Dec 31, 2021

Codecov Report

Merging #1427 (3860062) into main (4a01cb8) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1427      +/-   ##
==========================================
+ Coverage   92.00%   92.04%   +0.03%     
==========================================
  Files         175      175              
  Lines       14124    14169      +45     
==========================================
+ Hits        12995    13042      +47     
+ Misses       1129     1127       -2     
Flag Coverage Δ
unittests 92.04% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/core/tiling/deserialize.py 93.65% <ø> (ø)
hub/api/tests/test_api_tiling.py 100.00% <100.00%> (ø)
hub/core/chunk/base_chunk.py 98.18% <100.00%> (ø)
hub/core/compression.py 89.25% <100.00%> (+0.03%) ⬆️
hub/core/io.py 96.71% <100.00%> (+0.24%) ⬆️
hub/integrations/tests/test_pytorch.py 100.00% <100.00%> (ø)
hub/util/storage.py 92.98% <0.00%> (-3.51%) ⬇️
hub/core/chunk_engine.py 94.86% <0.00%> (-0.36%) ⬇️
hub/integrations/pytorch/dataset.py 92.91% <0.00%> (+1.57%) ⬆️
hub/integrations/tests/test_pytorch_dataloader.py 97.84% <0.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a01cb8...3860062. Read the comment docs.

Copy link
Contributor

@farizrahman4u farizrahman4u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test + fix lint

@AbhinavTuli AbhinavTuli merged commit 6cf888b into main Jan 12, 2022
@AbhinavTuli AbhinavTuli deleted the tiling+pytorch branch January 12, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants