Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AL - 1596] Dataset view saving #1380

Merged
merged 77 commits into from
Jan 23, 2022
Merged

[AL - 1596] Dataset view saving #1380

merged 77 commits into from
Jan 23, 2022

Conversation

farizrahman4u
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

Save dataset views like:

https://activeloop.atlassian.net/browse/AL-1596

ds = hub.datatset(.....)
view = ds[[1, 5, 7, 10]]
view.store("hub://...")

@CLAassistant
Copy link

CLAassistant commented Dec 8, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #1380 (9e29f6a) into main (a590eb2) will increase coverage by 0.17%.
The diff coverage is 88.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1380      +/-   ##
==========================================
+ Coverage   92.13%   92.31%   +0.17%     
==========================================
  Files         178      178              
  Lines       14322    14714     +392     
==========================================
+ Hits        13196    13583     +387     
- Misses       1126     1131       +5     
Flag Coverage Δ
unittests 92.31% <88.79%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/core/storage/gcs.py 73.91% <50.00%> (-0.31%) ⬇️
hub/core/query/query.py 83.33% <64.70%> (-2.48%) ⬇️
hub/core/query/filter.py 87.35% <85.24%> (+25.58%) ⬆️
hub/core/storage/s3.py 73.77% <85.71%> (+0.17%) ⬆️
hub/core/index/index.py 85.79% <87.50%> (+0.08%) ⬆️
hub/core/dataset/hub_cloud_dataset.py 89.74% <90.00%> (+0.75%) ⬆️
hub/core/dataset/dataset.py 93.53% <90.27%> (-0.24%) ⬇️
hub/util/tag.py 87.50% <92.30%> (+7.50%) ⬆️
hub/api/info.py 87.77% <100.00%> (+0.27%) ⬆️
hub/api/tests/test_events.py 100.00% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a590eb2...9e29f6a. Read the comment docs.

@tatevikh tatevikh requested a review from AbhinavTuli December 13, 2021 00:48
@farizrahman4u farizrahman4u added the trigger-test Label trigger to run tests on PRs label Jan 18, 2022
@gautamkrishnar gautamkrishnar added trigger-test Label trigger to run tests on PRs and removed trigger-test Label trigger to run tests on PRs labels Jan 18, 2022
@farizrahman4u farizrahman4u added trigger-test Label trigger to run tests on PRs and removed trigger-test Label trigger to run tests on PRs labels Jan 19, 2022
@activeloop-bot activeloop-bot removed the trigger-test Label trigger to run tests on PRs label Jan 19, 2022
@farizrahman4u farizrahman4u merged commit abc19ec into main Jan 23, 2022
@farizrahman4u farizrahman4u deleted the fr_ds_view_save branch January 23, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants