Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AL-1591] Add visualizer link when loading hub datasets #1367

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

farizrahman4u
Copy link
Contributor

@farizrahman4u farizrahman4u commented Dec 1, 2021

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

Add visualizer link when loading hub datasets
https://activeloop.atlassian.net/browse/AL-1591

@farizrahman4u farizrahman4u changed the title [AL - 1591] Add visualizer when loading hub datasets [AL - 1591] Add visualizer link when loading hub datasets Dec 1, 2021
@CLAassistant
Copy link

CLAassistant commented Dec 1, 2021

CLA assistant check
All committers have signed the CLA.

@farizrahman4u farizrahman4u changed the title [AL - 1591] Add visualizer link when loading hub datasets [AL-1591] Add visualizer link when loading hub datasets Dec 1, 2021
@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #1367 (8d8958d) into main (ca7e985) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 8d8958d differs from pull request most recent head 1e888f0. Consider uploading reports for the commit 1e888f0 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1367   +/-   ##
=======================================
  Coverage   92.09%   92.09%           
=======================================
  Files         158      158           
  Lines       11600    11601    +1     
=======================================
+ Hits        10683    10684    +1     
  Misses        917      917           
Flag Coverage Δ
unittests 92.09% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/core/dataset/hub_cloud_dataset.py 91.78% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca7e985...1e888f0. Read the comment docs.

@farizrahman4u farizrahman4u merged commit 944e1b3 into main Dec 1, 2021
@farizrahman4u farizrahman4u deleted the fr_viz_msg branch December 1, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants