Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to ensure agreement isn't reloaded for each slice of dataset #1347

Merged
merged 4 commits into from
Nov 22, 2021

Conversation

AbhinavTuli
Copy link
Contributor

@AbhinavTuli AbhinavTuli commented Nov 20, 2021

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

Ensures that the dataset agreement is only loaded once for each Dataset instance

@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Merging #1347 (b9c8532) into main (f8ae4be) will increase coverage by 0.80%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1347      +/-   ##
==========================================
+ Coverage   90.11%   90.91%   +0.80%     
==========================================
  Files         146      146              
  Lines       10345    10511     +166     
==========================================
+ Hits         9322     9556     +234     
+ Misses       1023      955      -68     
Flag Coverage Δ
unittests 90.91% <94.73%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub/core/dataset/hub_cloud_dataset.py 91.78% <93.75%> (+5.34%) ⬆️
hub/api/tests/test_pickle.py 100.00% <100.00%> (ø)
hub/core/dataset/dataset.py 93.47% <100.00%> (+0.14%) ⬆️
hub/cli/commands.py 100.00% <0.00%> (ø)
hub/api/tests/test_json.py 100.00% <0.00%> (ø)
hub/api/tests/test_text.py 100.00% <0.00%> (ø)
hub/tests/cache_fixtures.py 100.00% <0.00%> (ø)
hub/core/storage/provider.py 100.00% <0.00%> (ø)
hub/core/meta/dataset_meta.py 100.00% <0.00%> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8ae4be...b9c8532. Read the comment docs.

@aliubimov aliubimov added the trigger-test Label trigger to run tests on PRs label Nov 21, 2021
@activeloop-bot activeloop-bot removed the trigger-test Label trigger to run tests on PRs label Nov 21, 2021
@AbhinavTuli AbhinavTuli merged commit 960945f into main Nov 22, 2021
@AbhinavTuli AbhinavTuli deleted the fix/agreement_loading branch November 22, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants