Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jpeg fix issue with verify #1297

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Jpeg fix issue with verify #1297

merged 1 commit into from
Oct 26, 2021

Conversation

farizrahman4u
Copy link
Contributor

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

  • Fixes failing verify when SOS is right after shape.
  • Test files added to external repo

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #1297 (a8122f6) into main (5358e74) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1297      +/-   ##
==========================================
+ Coverage   91.17%   91.25%   +0.08%     
==========================================
  Files         141      141              
  Lines        9828     9828              
==========================================
+ Hits         8961     8969       +8     
+ Misses        867      859       -8     
Impacted Files Coverage Δ
hub/core/compression.py 89.88% <ø> (ø)
hub/core/lock.py 91.11% <0.00%> (+8.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5358e74...a8122f6. Read the comment docs.

@AbhinavTuli AbhinavTuli merged commit eb53b89 into main Oct 26, 2021
@AbhinavTuli AbhinavTuli deleted the fr_fix_verify branch October 26, 2021 13:12
@AbhinavTuli AbhinavTuli restored the fr_fix_verify branch November 4, 2021 13:05
@AbhinavTuli AbhinavTuli deleted the fr_fix_verify branch November 17, 2021 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants