Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pytest dependency error #1254

Merged
merged 3 commits into from
Oct 12, 2021
Merged

fix pytest dependency error #1254

merged 3 commits into from
Oct 12, 2021

Conversation

verbose-void
Copy link
Contributor

@verbose-void verbose-void commented Oct 12, 2021

🚀 🚀 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

non-testing hub code would still import pytests. this just removes that

@CLAassistant
Copy link

CLAassistant commented Oct 12, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #1254 (9fe6127) into main (5b49c96) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 9fe6127 differs from pull request most recent head f3f4942. Consider uploading reports for the commit f3f4942 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1254   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         135      135           
  Lines        9078     9078           
=======================================
  Hits         8319     8319           
  Misses        759      759           
Impacted Files Coverage Δ
hub/integrations/tests/test_pytorch.py 100.00% <100.00%> (ø)
hub/integrations/tests/test_tensorflow.py 100.00% <100.00%> (ø)
hub/tests/common.py 96.42% <100.00%> (+0.27%) ⬆️
hub/util/check_installation.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b49c96...f3f4942. Read the comment docs.

requires_tfds = pytest.mark.skipif(
not _tfds_installed(), reason="requires tensorflow_datasets to be installed"
)
return find_spec("ray") != None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint

Copy link
Member

@davidbuniat davidbuniat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you run a manual test if pytest dependancy exist in other locations?

@verbose-void
Copy link
Contributor Author

@davidbuniat i ran pip uininstall pytest then python with

>>> import hub

@verbose-void verbose-void merged commit e085e02 into main Oct 12, 2021
@verbose-void verbose-void deleted the fix/pytest-import branch October 12, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants