-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix pytest dependency error #1254
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1254 +/- ##
=======================================
Coverage 91.63% 91.63%
=======================================
Files 135 135
Lines 9078 9078
=======================================
Hits 8319 8319
Misses 759 759
Continue to review full report at Codecov.
|
hub/util/check_installation.py
Outdated
requires_tfds = pytest.mark.skipif( | ||
not _tfds_installed(), reason="requires tensorflow_datasets to be installed" | ||
) | ||
return find_spec("ray") != None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you run a manual test if pytest
dependancy exist in other locations?
@davidbuniat i ran
|
🚀 🚀 Pull Request
Checklist:
coverage-rate
upChanges
non-testing hub code would still import pytests. this just removes that