Update readme to remove ubuntu 18 and debian 10. Add better error reporting to the install script #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 3, 2023 21:53
…orted OS. Add better error reporting to installer to help explain why the installer crashes on unsupported OS
lisaSW
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zeek has removed support for Ubuntu 18 and Debian 10.
This PR updates the install script to output better error messages when installing in an unsupported environment and updates the list of supported OS's in the readme.
I've ran the installer in a bunch of docker containers and recorded the output from the old and new versions of the installer. I've attached them below. There are errors in the old version related to enable MongoDB at startup. These should be ignored since the tests were run in Docker containers and systemd is not enabled inside them. The new versions display these errors as warnings.
Debian 10 and Ubuntu 18 install successfully with the
--disable-zeekflag.Ubuntu 22 installs successfully with the
--disable-mongoflag.The old test_install.sh script was broken so it was removed.
Successful installs:
Successful installs without Zeek:
Successful installs without MongoDB:
Failed installations: