Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch to limit dataset timestamp range to 24 hours #743

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Patch to limit dataset timestamp range to 24 hours #743

merged 1 commit into from
Aug 17, 2022

Conversation

lisaSW
Copy link
Contributor

@lisaSW lisaSW commented Aug 17, 2022

  • since zeek records connections when they close, some connections that started before the ingested observation period can skew the ts range. We need to cap observation period to the last 24 hours for accurate beaconing analysis.

@lisaSW lisaSW requested a review from Zalgo2462 August 17, 2022 17:20
Zalgo2462
Zalgo2462 approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@Zalgo2462 Zalgo2462 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well. LGTM.

@Zalgo2462 Zalgo2462 merged commit 7865c91 into master Aug 17, 2022
@Zalgo2462 Zalgo2462 deleted the beacons-scoring-patch branch August 17, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zalgo2462 Zalgo2462 Zalgo2462 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lisaSW @Zalgo2462