Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create FQDN beacon analysis progress bar if there are no FQDNs to update #700

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

Zalgo2462
Copy link
Contributor

@Zalgo2462 Zalgo2462 commented Aug 25, 2021

Fixes #699

To test: import a dataset (without chunking/ rolling) without any DNS logs. master will freeze. This branch will display [!] No FQDN Beacon data to analyze and continue.

When viewing the diff, please select "Hide whitespace changes" using the gear at the top of the file display.

@Zalgo2462 Zalgo2462 changed the title Don't create progress bar if there are no FQDNs to update Don't create FQDN Beaconing progress bar if there are no FQDNs to update Aug 25, 2021
@Zalgo2462 Zalgo2462 changed the title Don't create FQDN Beaconing progress bar if there are no FQDNs to update Don't create FQDN beacon analysis progress bar if there are no FQDNs to update Aug 25, 2021
Copy link

@0x6d6f7468 0x6d6f7468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Zalgo2462 Zalgo2462 merged commit 4a4b639 into master Aug 26, 2021
@Zalgo2462 Zalgo2462 deleted the 699-fix-fqdn-beaconing-freeze-no-dns branch August 26, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FQDN beacon analysis freezes when there are no DNS logs in the dataset
2 participants