Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Need for Users to Specify Proxy Servers, Fix Filter Bugs #665

Merged
merged 5 commits into from
Jul 22, 2021

Conversation

fullmetalcache
Copy link
Contributor

@fullmetalcache fullmetalcache commented Jul 22, 2021

Removes the need for a user to specify their proxy servers for the beacons proxy module. Now, all http.log entries with the CONNECT method will automatically be considered for processing for the beacons proxy module. Entries will also be ignored if the Src IP or FQDN have been specified for filtering.

This also ensure that entries are not filtered if they are an internal->internal connection

Closes #664

Copy link
Contributor

@Zalgo2462 Zalgo2462 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested well. Code change looks good.

These changes will need to be reflected in #654.

@Zalgo2462 Zalgo2462 merged commit e6c740f into master Jul 22, 2021
@Zalgo2462 Zalgo2462 deleted the 664-proxy-module-updates branch July 22, 2021 22:16
@Zalgo2462 Zalgo2462 mentioned this pull request Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process all CONNECT Entries for Beacons Proxy Module
2 participants