Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting parent_controller #903

Merged

Conversation

jaynetics
Copy link
Contributor

fixes #618

for the interface, i mirrored Devise::parent_controller=.

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (43645af) to head (f604919).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #903   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files          14       14           
  Lines         557      558    +1     
=======================================
+ Hits          551      552    +1     
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaynetics jaynetics force-pushed the support-setting-parent-controller branch from 405c7c7 to a156fb0 Compare July 14, 2024 09:16
@jaynetics
Copy link
Contributor Author

rebased to bring up-to-date with master.

@tagliala could we get this one merged?

@jaynetics jaynetics force-pushed the support-setting-parent-controller branch 2 times, most recently from 78d7b34 to 817d23d Compare July 15, 2024 08:41
@tagliala
Copy link
Contributor

tagliala commented Nov 9, 2024

I think this may be an interesting change, I may need this for a use case where I want to alias current_admin_user to current_user and add some other admin-specific actions

@jaynetics
Copy link
Contributor Author

My use case is the same as in the original issue: running rails in API mode.

I've been using this fork and the setting parent_controller = 'ActionController::Base' in production for 8 months now without issues.

@tagliala tagliala requested a review from javierjulio December 1, 2024 08:43
@javierjulio javierjulio force-pushed the support-setting-parent-controller branch from 541753d to 10d85a7 Compare December 7, 2024 16:12
Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tagliala tagliala merged commit 8a20bdf into activeadmin:master Dec 7, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to provide another superclass other than ApplicationController
4 participants