Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove table tag defaults #542

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Remove table tag defaults #542

merged 1 commit into from
Oct 24, 2023

Conversation

javierjulio
Copy link
Member

@javierjulio javierjulio commented Oct 8, 2023

These are unnecessary for a long time now as they can be controlled easily through CSS. It would be best to have no overrides for these elements (other than p/para due to the name clash).

This will be in a major (v2) release due to being a breaking change.

@javierjulio javierjulio self-assigned this Oct 8, 2023
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8164455) 91.57% compared to head (ae866e6) 92.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #542      +/-   ##
==========================================
+ Coverage   91.57%   92.48%   +0.91%     
==========================================
  Files          17       17              
  Lines         475      466       -9     
==========================================
- Hits          435      431       -4     
+ Misses         40       35       -5     
Files Coverage Δ
lib/arbre/html/html5_elements.rb 100.00% <ø> (+29.41%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

These are unnecessary for a long time now as they can be controlled easily through CSS. It would be best to have no overrides for these elements (other p/para due to the name clash).
@javierjulio javierjulio force-pushed the remove-table-tag-defaults branch from 455985b to ae866e6 Compare October 24, 2023 21:31
@javierjulio javierjulio merged commit 22a71a3 into master Oct 24, 2023
22 checks passed
@javierjulio javierjulio deleted the remove-table-tag-defaults branch October 24, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant