Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to sh on non-Windows #14

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Conversation

ncfavier
Copy link
Contributor

Fixes #13

@ncfavier ncfavier requested a review from a team as a code owner August 16, 2022 22:04
@yoannchaudet
Copy link
Contributor

Will get that merged after #16 which adds some tests so we don't regress anything.

@JamesMGreene
Copy link
Contributor

JamesMGreene commented Aug 19, 2022

My suspicion is that we would actually be safer by just not specifying the shell and allowing Actions to try for the bash executable and then fallback to sh if it wasn't found. The documentation seems to read like specifying bash explicitly will also fallback like that but it sounds like that may not be the case based on the report in #13. 🤔

@ncfavier
Copy link
Contributor Author

Weirdly enough, removing shell in the action fails: https://github.com/ncfavier/1lab/runs/7919247403?check_suite_focus=true

@JamesMGreene
Copy link
Contributor

JamesMGreene commented Aug 19, 2022

Ah, yeah, there it is in the docs. 🔍

runs.steps[*].shell

Optional The shell where you want to run the command. You can use any of the shells listed here.
👉🏻 Required if run is set. 👈🏻

My apologies for recommending it without reading the composite Actions docs further. 😅
Thanks for the catch, @ncfavier! 🙇🏻‍♂️

@ncfavier
Copy link
Contributor Author

Any updates on this?

Copy link
Contributor

@yoannchaudet yoannchaudet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 !

@yoannchaudet yoannchaudet merged commit aff0f43 into actions:main Nov 1, 2022
@ncfavier ncfavier deleted the patch-1 branch November 1, 2022 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary dependency on bash
3 participants