-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix zstd failing on windows when used with the gnu tar workaround #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct the same. Fix --d to -d in comments.
lvpx
force-pushed
the
pdotl-zstd-win-patch
branch
from
August 17, 2022 08:33
c1a7558
to
98a4069
Compare
bishal-pdMSFT
approved these changes
Aug 17, 2022
lvpx
force-pushed
the
pdotl-zstd-win-patch
branch
from
August 18, 2022 11:02
a3159a1
to
ce68daa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve the issues #888 and #891 in
actions/cache
.Context
We had introduced zstd aliases in
actions/cache
v3.0.6
to fix issues with zstd failing for tar version < 1.30. That change was made in understanding that we have zstd disabled on windows(bsd tar). However, due to dismal gzip performance on windows runners, developers have been using a workaround to use gnu tar along with zstd. The above release broke this workaround.Approach
We have switched to using short flag versions(ex.
zstd -d
) of zstd command for windows on gnu tar instead of the alias versions(ex.unzstd
). This restores the workaround functionality same as before the releasev3.0.6
. This approach has been implemented in this PR.The downsides of using this approach:
Alternative Approach
We also considered reverting the change done in
v3.0.6
and instead implement zstd aliases based on tar versions. This would also work correctly as it has been working before. We only use zstd aliases for tar version < 1.30.The downside of using this approach:
Feedback is welcome for choosing between both approaches and code review as well. 👀