Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(milestones): add new options to exempt all milestones #291

Merged
merged 26 commits into from
Feb 16, 2021

Conversation

C0ZEN
Copy link
Contributor

@C0ZEN C0ZEN commented Jan 24, 2021

Note:
It was created from #290 so it would be better to merge it first.
It would be cooler if #289 can be merged before too so that the beta or alpha release can be tested.

Changes:

  • Create more spec files to test the general behaviour of the stale action
  • Move into their own files the utils code to test the general behaviour of the stale action
  • Refactor the tests for the milestones
    • Add coverage for issues AND pull requests as it should
    • Create a more nested structure to be more logical and make sure no cases was forgotten
    • Note: damn this is a 10k rows kind of spec file... since there is now 6 options playing altogether with the milestones there is a bunch of possible config combinations and I am pretty sure to cover them all at this cost. Any suggestion is welcome
  • Create a tsconfig for the spec and for the app to make sure eslint AND jest find the right files at any moment
  • Rename the pr wordings to make it more consistent and more user-friendly
  • Add new options to ignore all issues and PRs with milestones with their respective sub-options to do that only for issues OR pull requests - the option has a better priority than the current exempt milestones options

Closes #283

@C0ZEN
Copy link
Contributor Author

C0ZEN commented Jan 28, 2021

With this refactor it reduces the spec LOC from 10k to 3.4k.
I still think that this is possible to improve it even more to have at the end a single matrix which can be quite easier to read through but I spent way too much time already on this that I am fine for this ;)

@hross
Copy link
Contributor

hross commented Feb 13, 2021

@C0ZEN this one is going to need a rebase to merge

@C0ZEN C0ZEN force-pushed the feature/milestones branch from f5eda6c to 893485c Compare February 13, 2021 11:48
@C0ZEN
Copy link
Contributor Author

C0ZEN commented Feb 13, 2021

@hross hello and thank you for the feedbacks. I rebased this one and reviewed it, seems ready to go IMO.

@hross hross merged commit 6a49376 into actions:main Feb 16, 2021
@C0ZEN C0ZEN deleted the feature/milestones branch February 16, 2021 21:21
@C0ZEN
Copy link
Contributor Author

C0ZEN commented Feb 16, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid stale for all milestones
2 participants