fix(remove-label): do not encode the label to make sure to remove it #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
both are failing
meaning that I did not find a reproduction...
could lead to an issue since based on the comment it was here on purpose
|
Tried this pr and it works ok with slashes in label. Could maintainers check these changes! |
hross
approved these changes
Jan 15, 2021
|
Thank you |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
encodeURIComponentwhen calling the GitHub API to remove a label.The documentation is not specifying anything regarding special comments so it could work but I was not able to test it.
Fixes #173.