Problem matchers: Don't require relative paths to start with ./ or ../ #98
Conversation
Errors reported by Go, even when containing relative paths, do not always begin with ./ or ../ – for example: $ go build ./... # honnef.co/go/tools/lintcmd lintcmd/format.go:28:8: syntax error: cannot use path := filepath.Clean(pos.Filename) as value We could require either ./, ../ or at least one path separator and still match Go's output. However, commonly used linters (such as Staticcheck and golint) never use ./ for relative paths. Their output stopped being matched when we moved from v1 to v2. I believe that being able to match the output of linters is worth relaxing the pattern for. This change slightly relaxes the stricter pattern that was introduced as part of v2 to address actions#46. However, the pattern is still stricter than it was in v1 and as strict as it can be for most users.
|
Friendly ping |
|
Not sure who's maintaining this repo. @joshmgross, @thboop or @bryanmacfarlane maybe? |
|
@marten-seemann In the meantime I can recommend https://github.com/WillAbides/setup-go-faster |
|
Any idea on how the regex compares to the one VS Code uses? I believe that's where the original one was pulled. |
bryanmacfarlane
changed the title
|
related setup-node PR which compared to and pulled from vs code: actions/setup-node#125 |
|
@bryanmacfarlane I don't think the author or anyone else in this thread is involved with VS Code. I hope it's clear that, from the original post here, the current regular expression isn't right. I personally don't mind what the final fix ends up being, but we do need a fix sooner than later :) |
|
Exasperated ping. |
|
@maxim-lobanov can ya'll take a look at this PR? |
There was a problem hiding this comment.
@dmitry-shibanov @MaksimZhukov could you please proceed with accepting these changes if they look good to you.
Errors reported by Go, even when containing relative paths, do not
always begin with ./ or ../ – for example:
We could require either ./, ../ or at least one path separator and
still match Go's output. However, commonly used linters (such as
Staticcheck and golint) never use ./ for relative paths. Their output
stopped being matched when we moved from v1 to v2. I believe that
being able to match the output of linters is worth relaxing the
pattern for.
This change slightly relaxes the stricter pattern that was introduced
as part of v2 to address #46. However, the pattern is still stricter
than it was in v1 and as strict as it can be for most users.