Add support for deleting packages on new GitHub Packages architecture #83
Conversation
| expect(result.versions.length).toBe(numVersions) | ||
| done() | ||
| }) | ||
| const RATE_LIMIT = 99 |
There was a problem hiding this comment.
The RATE_LIMIT was a limitation due to limitation of graphql api. Do we have the same limitation with REST or can it be updated/removed?
There was a problem hiding this comment.
The delete version rest API works for a single version deletion only; hence no concept of rate-limiting here. However, I still think that we should rate-limit deletions in a single workflow. We can decide on the limit value.
There was a problem hiding this comment.
The rate limit is 1000 requests per repository per hour when using GITHUB_TOKEN and 5000 requests per user per hour when using PAT. Considering the limit with GITHUB_TOKEN, I think 100 is sufficient as we would not want this workflow to exhaust a significant part of limit and possibly cause issue with other workflows.
There was a problem hiding this comment.
Changed to 100 - 2de4236
src/delete.ts
Outdated
| new Date(a.created_at).getTime() - new Date(b.created_at).getTime() | ||
| ) | ||
| }) | ||
| /* | ||
| Here first filter out the versions that are to be ignored. | ||
| Then update input.numOldeVersionsToDelete to the no of versions deleted from the next 100 versions batch. |
There was a problem hiding this comment.
Can we remove the batch part from the comment.
There was a problem hiding this comment.
Changed the comment in 2de4236
action.yml
Outdated
|
|
||
| package-type: | ||
| description: > | ||
| Type of the package containing the version to delete. |
There was a problem hiding this comment.
nit: the language here can be clearer since this is a customer facing help string for the param
There was a problem hiding this comment.
Changed to 👇 (2de4236)
Type of package. Can be one of container, maven, npm, nuget, or rubygems.
nishthaGupta
dismissed stale reviews from NamrataJha and suyash691
via
4833470
Overview
Package registries on the new GitHub Packages architecture, including container registry, npm and nuget packages, no longer expose data through the GraphQL API. This action currently relies on using GraphQL to get and delete versions, thus making it incompatible with the new architecture
In this PR, we replace the GraphQL dependency with GitHub REST API for Packages along with some other changes and improvements
Changes
min-versions-to-keepis given. Now all versions are first fetched and then processed in a single batchChanges in action parameters
package-typeparam which is required in the REST APIsrepoparam as it is no longer neededpackage-nameparam required even ifpackage-version-idsis specifiedRelated