Njb/nest module #840

NickBolles · 2019-10-18T08:06:14Z

Looking for testers for a nestjs module. Please let me know if there's anything We can do better, especially pay attention to creating a new package in the monorepo and the package metadata. I wasn't 100% sure I have it all accurate.

TrejGun · 2019-11-06T06:51:10Z

packages/nestjs/src/guards/Auth.guard.ts

+        const gqlParams: GQLParam = [ctx.getRoot(), ctx.getArgs(), gqlCtx, ctx.getInfo()];
+        // use the authenticated function from accounts-js. All that's really needed is context
+        await authenticated(() => null)(...gqlParams);
+        return this.runValidators(gqlCtx.user, context, gqlParams);


is it gqlCtx.req.user?

yea, I think you're right

How does this test pass tho? Does accounts set

Test cases: https://github.com/NickBolles/accounts/blob/njb/nest-module/packages/nestjs/examples/with-auth-guard/e2e/app.e2e-spec.ts#L220-L282

Resolver: https://github.com/NickBolles/accounts/blob/njb/nest-module/packages/nestjs/examples/with-auth-guard/DarthsResolver.ts

Actually, no what I have is correct. This is where Accounts.js builds the context, it sets user, as well as some more properties on the context.

https://github.com/accounts-js/accounts/blob/master/packages/graphql-api/src/utils/context-builder.ts#L37-L43

Interestingly, it doesn't set the request on the context, but it looks like it requires it to be set on the context by something else earlier on

packages/nestjs/README.md

ducan-ne · 2019-12-04T18:02:06Z

nice PR, I'm waiting for merge!

NickBolles · 2019-12-07T04:34:32Z

@Quaj Have you tested it out? I was using it my app but I haven;t been working on it lately.

ducan-ne · 2019-12-08T09:58:54Z

@Quaj Have you tested it out? I was using it my app but I haven;t been working on it lately.

not yet, but i thinks need some refactor

NickBolles · 2019-12-08T18:40:02Z

not yet, but i thinks need some refactor

You mean your app would or this PR does? Feel free to review and add comments

NickBolles · 2020-02-04T14:33:50Z

Still looking for review on this @Quaj and @TrejGun would you be interested in actually trying this out? You should be able to do an NPM install from my github branch, otherwise pull it, run yarn link and then do a yarn link @accounts/nestjs in your app folder

leesiongchan · 2020-03-18T07:43:43Z

I am interested in checking this out, but do you think if you can bump to the latest nest v7? And do you think it is possible to include Federation support?

elie222 · 2020-03-18T09:39:30Z

Nest 7 is slightly buggy atm Best, Eliezer

…

On Wed, Mar 18 2020 at 9:43 AM, Lee Siong Chan < ***@***.*** > wrote: I am interested in checking this out, but do you think if you can bump to the latest nest v7? And do you think it is possible to include Federation support? — You are receiving this because you commented. Reply to this email directly, view it on GitHub ( #840 (comment) ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AAXSQX4LQXCENF5VQTUIR4DRIB3TZANCNFSM4JCD7GXQ ).

TrejGun · 2020-03-19T05:33:56Z

have not saw bugs yet, can you point please

elie222 · 2020-03-19T09:20:49Z

They’ve fixed a few since my post. For example not being able to use args in field resolvers Best, Eliezer

…

On Thu, Mar 19 2020 at 7:34 AM, Trej Gun < ***@***.*** > wrote: have not saw bugs yet, can you point please — You are receiving this because you commented. Reply to this email directly, view it on GitHub ( #840 (comment) ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AAXSQX4SDYDSUGMPLB5GXEDRIGVFBANCNFSM4JCD7GXQ ).

NickBolles · 2020-03-20T03:15:22Z

@leesiongchan

I am interested in checking this out, but do you think if you can bump to the latest nest v7? And do you think it is possible to include Federation support?

Is there some incompatiblity? Maybe we can loosen up the peer dependency range for @nestjs/core. I don't remember any part of this module relying on nest directly. Give it a shot. Download the module and run E2E tests with nest 7. The E2E tests are very robust.

leesiongchan · 2020-03-20T08:00:31Z

@leesiongchan

I am interested in checking this out, but do you think if you can bump to the latest nest v7? And do you think it is possible to include Federation support?

Is there some incompatiblity? Maybe we can loosen up the peer dependency range for @nestjs/core. I don't remember any part of this module relying on nest directly. Give it a shot. Download the module and run E2E tests with nest 7. The E2E tests are very robust.

Yes you have to rename all type-graphql to @nestjs/graphql, see https://docs.nestjs.com/migration-guide#graphql

agustif · 2020-04-27T12:03:59Z

Anyone got NestJS to work with AccountsJS?

NickBolles · 2020-04-29T00:45:27Z

@agustif have you tried this package with next 6.x?

agustif · 2020-04-29T10:24:45Z

@agustif have you tried this package with next 6.x?

Nope, I havent tried yet.
But I like the idea of both using AccountsJS and NestJS for my project's backend.

I also plan to not use angular but React/NextJS on the frontend, but I guess that shouldn't affect muchh the other parts of the stack since all communication happens between grahpql/apollo/express etc...

agustif · 2020-05-01T18:56:59Z

@agustif have you tried this package with next 6.x?

Does it work only with v6? Any plans for v7 support? I might skip nestJS for now as I will have a pretty simple backend on top of AccountsJS User System

elie222 · 2020-05-02T18:00:02Z

Worth skipping if it's a simple project and you already have accounts working Best, Eliezer

…

On Fri, May 01, 2020 at 9:57 PM, Agusti Fernandez < ***@***.*** > wrote: > > > @ agustif ( https://github.com/agustif ) have you tried this package with > next 6.x? > > Does it work only with v6? Any plans for v7 support? I might skip nestJS for now as I will have a pretty simple backend on top of AccountsJS User System — You are receiving this because you commented. Reply to this email directly, view it on GitHub ( #840 (comment) ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AAXSQXYSPAUSCMPLIQPRA6TRPMLQVANCNFSM4JCD7GXQ ).

NickBolles · 2020-05-06T23:40:52Z

I can update it to v7, I just updated my app and it was literally a find and replace. Then update context guards to be more robust.

@elie222 how are you doing auth guards and such with nestjs?

elie222 · 2020-05-07T08:15:03Z

Auth guards (I'm using Auth0 in examples below). Not using AccountsJS atm:

  @Query(() => Number)
  @UseGuards(GqlAuthGuard, RolesGuard)
  @Roles('admin')
  async studentsCount() {
    return this.studentService.count()
  }

@Injectable()
export class GqlAuthGuard extends AuthGuard('jwt') {
  getRequest(context: ExecutionContext) {
    const ctx = GqlExecutionContext.create(context)
    return ctx.getContext().req
  }
}

@Injectable()
export class RolesGuard implements CanActivate {
  constructor(
    private readonly reflector: Reflector,
    private readonly configService: ConfigService
  ) {}

  canActivate(context: ExecutionContext): boolean | Promise<boolean> | Observable<boolean> {
    const routeRoles = this.reflector.get<string[]>('roles', context.getHandler())

    if (!routeRoles) return true

    const ctx = GqlExecutionContext.create(context)
    const user = ctx.getContext().req.user
    const userRoles = user[this.configService.get('AUTH0_ROLES_FIELD')] || []

    return hasRole(routeRoles, userRoles)
  }
}

NickBolles added 4 commits October 18, 2019 08:04

feat: NestJS Module

3221a8e

fix: fix build issues with new typescript settings

02762b3

fix(nestjs): use User type from @accounts/types

1af9dc6

fix(nestjs): small spelling fix

6854823

NickBolles mentioned this pull request Oct 24, 2019

Support for @nestjs/graphql #506

Open

TrejGun reviewed Nov 6, 2019

View reviewed changes

darkbasic force-pushed the master branch 6 times, most recently from 3d3efb6 to 20969e7 Compare September 13, 2023 15:57

darkbasic force-pushed the master branch 3 times, most recently from bdf442b to 3e57ec8 Compare September 13, 2023 17:04

darkbasic force-pushed the master branch from e4b593a to 1637b35 Compare September 25, 2023 17:57

darkbasic force-pushed the master branch from acef284 to c4c6e6d Compare November 20, 2023 16:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Njb/nest module #840

Njb/nest module #840

NickBolles commented Oct 18, 2019 •

edited

Loading

TrejGun Nov 6, 2019

NickBolles Nov 14, 2019

NickBolles Nov 14, 2019

NickBolles Nov 14, 2019

ducan-ne commented Dec 4, 2019

NickBolles commented Dec 7, 2019

ducan-ne commented Dec 8, 2019

NickBolles commented Dec 8, 2019

NickBolles commented Feb 4, 2020

leesiongchan commented Mar 18, 2020

elie222 commented Mar 18, 2020 via email

TrejGun commented Mar 19, 2020

elie222 commented Mar 19, 2020 via email

NickBolles commented Mar 20, 2020 •

edited

Loading

leesiongchan commented Mar 20, 2020

agustif commented Apr 27, 2020

NickBolles commented Apr 29, 2020

agustif commented Apr 29, 2020

agustif commented May 1, 2020

elie222 commented May 2, 2020 via email

NickBolles commented May 6, 2020

elie222 commented May 7, 2020

Njb/nest module #840

Are you sure you want to change the base?

Njb/nest module #840

Conversation

NickBolles commented Oct 18, 2019 • edited Loading

TrejGun Nov 6, 2019

Choose a reason for hiding this comment

NickBolles Nov 14, 2019

Choose a reason for hiding this comment

NickBolles Nov 14, 2019

Choose a reason for hiding this comment

NickBolles Nov 14, 2019

Choose a reason for hiding this comment

ducan-ne commented Dec 4, 2019

NickBolles commented Dec 7, 2019

ducan-ne commented Dec 8, 2019

NickBolles commented Dec 8, 2019

NickBolles commented Feb 4, 2020

leesiongchan commented Mar 18, 2020

elie222 commented Mar 18, 2020 via email

TrejGun commented Mar 19, 2020

elie222 commented Mar 19, 2020 via email

NickBolles commented Mar 20, 2020 • edited Loading

leesiongchan commented Mar 20, 2020

agustif commented Apr 27, 2020

NickBolles commented Apr 29, 2020

agustif commented Apr 29, 2020

agustif commented May 1, 2020

elie222 commented May 2, 2020 via email

NickBolles commented May 6, 2020

elie222 commented May 7, 2020

NickBolles commented Oct 18, 2019 •

edited

Loading

NickBolles commented Mar 20, 2020 •

edited

Loading