fix typings for AccountsClientPassword #825
Conversation
|
@pradel any idea why this is failing the checks? it says no linked package "@accounts/password"... shouldn't lerna be linking them all up correctly? build works locally for me |
| let hashedPassword = user.password; | ||
| if (typeof user.password === 'string') { | ||
| // mostly just a type check | ||
| hashedPassword = this.hashPassword(user.password); |
There was a problem hiding this comment.
does this line is necessary? server stil throw a error if user.password is number, booolean
There was a problem hiding this comment.
The point of the PR is to fix a possibly null error I believe. It's been a while. But if that's the case hashPassword typings should allow non-string inputs then, which seems a little more messy to me.
There was a problem hiding this comment.
Right, so the point of this fix is to fix a typescript compile issue. Honestly this fix might not be needed. I forget why I was running into it. Maybe it was just a warning
|
Fixed by #893 |
Closes #818