Rework loading the NOTICE from a NOTICE file #468
Labels
Comments
Do not worry, this is a tricky part in wheels and rather easy to get past it. A file that not inside a package is not readily accessible in a wheel (even though you can get to it in development). This is also an area that is and has been the subject of a lot of discussions. See:
Now, I started pushing a wheel a while ago but only on Github releases for now: https://github.com/nexB/scancode-toolkit/releases ... The goal is to to make this a Pypi wheel with 2.0. This was not caught only because there is not a test for this! |
pombredanne
added a commit
that referenced
this issue
Feb 17, 2017
* this is a first step towards #381 * code and tests have been split from the scancode module * Also restore the ability to run ScanCode as a library by vendoring the NOTICE file. This was a regression introduced in #424 and tracked as #468 Signed-off-by: Philippe Ombredanne <[email protected]>
|
This is working again now and is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This was introduced in #424
But this https://github.com/nexB/scancode-toolkit/pull/424/files#diff-1e37ecfb9a8c3fccd8ecdfb2ce51f591R104 is making an assumption about the location of the NOTICE file which does not hold in a built wheel (the NOTICE is not
package datasetup-wise)The text was updated successfully, but these errors were encountered: