New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dependency on meteorhacks:meteorx #25

Closed

macrozone opened this issue Nov 30, 2018 · 1 comment · Fixed by #26

macrozone commented Nov 30, 2018

meteorhacks:meteorx is unmaintained and breaks with the latest meteor version. See meteorhacks/meteorx#8

I don't think that forking meteorx is a good idea. Maybe we should rather backport some of the apis its exposes to meteor itself.

benjamn added a commit to meteor/meteor-apm-agent that referenced this issue


          Remove meteorhacks:meteorx dependency.

0e2861d

This commit brings the relevant bits of meteorhacks:meteorx into the
mdg:meteor-apm-agent package, so that various issues can be fixed without
forking or continuing to maintain meteorhacks:meteorx.

Related:
meteor/meteor#10337 (comment)
meteorhacks/meteorx#8
meteorhacks/meteorx#9
abecks/meteor-fast-render#25

benjamn mentioned this issue

Remove meteorhacks:meteorx dependency. meteor/meteor-apm-agent#7

Merged

Author

macrozone commented Dec 2, 2018

maybe use this https://github.com/lamhieu-vk/meteorx

macrozone mentioned this issue

replace meteorhacks:meteorx with lamhieu:meteorx #26

Merged

abecks closed this as completed in #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment