Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put a "Previous" and "Next" button #129

Open
sheesh3178 opened this issue Oct 27, 2024 · 5 comments
Open

Put a "Previous" and "Next" button #129

sheesh3178 opened this issue Oct 27, 2024 · 5 comments

Comments

@sheesh3178
Copy link

There's no button for it, so I can't do it. I tried putting one with autoload.lua just like I do with MPV, but it didn't work for some reason.

My action:

  • Install app
  • Play video
  • Notice that it has no "Previous" and "Next" button, just like with MPV
  • Put autoload.lua on a folder
  • Link with mpv.conf
  • Doesn't work
@abdallahmehiz
Copy link
Owner

Once playlists are implemented.

@sheesh3178
Copy link
Author

sheesh3178 commented Oct 27, 2024 via email

@abdallahmehiz
Copy link
Owner

abdallahmehiz commented Oct 27, 2024

but it doesn't even work in this app

I am pretty sure it does... can you tell me what exactly isn't working?

and also is somewhat useless now because the dev is now putting all the necessary features for a proper video player - features that mpv lacked, making custom scripting pretty much useless.

well having the options to use custom scripts and configurations is nice since i can't possibly cover all use cases

@Pentaphon
Copy link

Once playlists are implemented.

@abdallahmehiz we also need the previous and next button for any autoplay since many people hate making playlists and prefer to just play all of the video files in a folder by default such as episode packs, etc.

I must ask though, what is the mpv.conf/input.conf even for now? I know
it's used to add additional features for the lacking mpv, but it doesn't
even work in this app, and also is somewhat useless now because the dev is
now putting all the necessary features for a proper video player - features
that mpv lacked, making custom scripting pretty much useless.

@sheesh3178 its for people who want total control of mpv like they do on the desktop. The developer is just adding features that should "just work" on a touchscreen player without having to edit .conf files on their phone or tablet but he's also not going to cover every single thing that most people will never fiddle with.

@sheesh3178
Copy link
Author

but it doesn't even work in this app

I am pretty sure it does... can you tell me what exactly isn't working?

the autoload.lua script

I tried everything to make it work. I set it up just like with mpv:

mpv.conf: script="/sdcard/path/to/autoload.lua" which in this case is sdcard/Movies/mpvKt/autoload.lua

But this time I set up the "pick mpv configuration storage location" to said path (in all honesty, I don't even know what is this setting for. I don't think this exists in mpv-android)

And surprise surprise, it doesn't work. I tried changing the mpv.conf like:
script="/Movies/mpvKt/autoload.lua",
script="/storage/0/emulated/Movies/mpvKt/autoload.lua"

tried removing the quotations here
script=/sdcard/Movies/mpvKt/autoload.lua,
script=/Movies/mpvKt/autoload.lua,
script=/storage/emulated/0/Movies/mpvKt/autoload.lua

removed the "script=" here
/sdcard/Movies/mpvKt/autoload.lua,
/Movies/mpvKt/autoload.lua,
/storage/emulated/0/Movies/mpvKt/autoload.lua

Still doesn't work.

I guess I'll have to wait for the playlist feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants