Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please publish new version #30

Closed
ebaauw opened this issue Oct 1, 2021 · 3 comments
Closed

Please publish new version #30

ebaauw opened this issue Oct 1, 2021 · 3 comments

Comments

@ebaauw
Copy link

ebaauw commented Oct 1, 2021

Could you please publish a new version with the latest commits (notably 8ddae50, which gets rids of the deprecation warnings when installing).

I ended up publishing local forks for noble and node-bluetooth-hci-socket, because I feared these libraries were no longer maintained, but I saw a recent PR being merged by @rzr into noble.

I really appreciate the work you're doing here and am more than willing to help where I can.

rzr added a commit to CrossStream/node-bluetooth-hci-socket that referenced this issue Oct 1, 2021
Relate-to: abandonware#30
Change-Id: I674793a2be5a3ed5decdba089ab9b78cd0febb6c
Signed-off-by: Philippe Coval <[email protected]>
rzr added a commit that referenced this issue Oct 1, 2021
Relate-to: #30
Change-Id: I674793a2be5a3ed5decdba089ab9b78cd0febb6c
Signed-off-by: Philippe Coval <[email protected]>
@rzr
Copy link

rzr commented Oct 1, 2021

It's done:
https://www.npmjs.com/package/@abandonware/bluetooth-hci-socket/v/0.5.3-8

Please confirm it's working as expected and close this thread.

And eventually report this on upstream tracker, ie:
noble#123

@ebaauw
Copy link
Author

ebaauw commented Oct 1, 2021

Thanks for the quick response. As far as I can tell it's working. I've updated my PR on noble (abandonware/noble#224) to use this version.

How do I report this on the upstream tracker?

@ebaauw ebaauw closed this as completed Oct 1, 2021
@rzr
Copy link

rzr commented Oct 1, 2021

maybe duplicate the ticket or just comment noble#122 to tell they are desirable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants