feat(editChannelPositions): add support for endpoint

[carloslimaborges]

Implements this part of Discord API: https://discord.com/developers/docs/resources/guild#modify-guild-channel-positions

[eritbh]

Would probably make sense to add a corresponding helper on Guild, and types for the new method(s) should be added to index.d.ts as well. The added code code looks fine to me though.

[carloslimaborges]

Would probably make sense to add a corresponding helper on Guild, and types for the new method(s) should be added to index.d.ts as well. The added code code looks fine to me though.

Done 😃

[bsian03]

Endpoint also accepts an audit log entry and thus should include reason when calling the method

[carloslimaborges]

Endpoint also accepts an audit log entry and thus should include reason when calling the method

I will need help on this one, cause the body I send is an array. And I can't add a reason to that array to send to the RequestHandler. Changing the RequestHandler for this made me a bit uncomfortable, considering this is my first big contribution.

[carloslimaborges]

Please check if it is ok after the changes

[eritbh]

the body I send is an array. And I can't add a reason to that array to send to the RequestHandler.

Maybe a little unorthodox, but manually assigning body.reason after the initial assignment should be fine. It doesn't look like the request handler does anything special other than reading that property and then deleting it, so I think this is a case where adding an extra property to an array is safe.

It might be better to restructure the request handler's request method to take an explicit argument for the X-Audit-Log header, or maybe an object argument for setting arbitrary headers, but that feels like a bigger change that would require updates to a bunch of other code at the same time. I'm not a maintainer, but my take is that sort of change should probably be a separate PR.

[carloslimaborges]

the body I send is an array. And I can't add a reason to that array to send to the RequestHandler.

Maybe a little unorthodox, but manually assigning body.reason after the initial assignment should be fine. It doesn't look like the request handler does anything special other than reading that property and then deleting it, so I think this is a case where adding an extra property to an array is safe.

It might be better to restructure the request handler's request method to take an explicit argument for the X-Audit-Log header, or maybe an object argument for setting arbitrary headers, but that feels like a bigger change that would require updates to a bunch of other code at the same time. I'm not a maintainer, but my take is that sort of change should probably be a separate PR.

It did work. So I finished the change.

[carloslimaborges]

Endpoint also accepts an audit log entry and thus should include reason when calling the method

I resolved this, how do I mark it as resolved at github?

[carloslimaborges]

Is there any change request I haven't dealt with yet? I get a little bit confused by the github interface, sorry

Outdated