Added delay if event type is keyup #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namezero111111
added a commit
to namezero111111/redmine_didyoumean
that referenced
this pull request
Sep 26, 2014
|
Thanks for taking care of this Edgar, the PR looks good, the only thing I'd ask is to make sure there's always a space before open brackets and braces ( |
|
I'll Work on it already |
|
Ready @abahgat |
|
Thanks, one more thing you might consider for the future, if you will, is to squash your cleanup and formatting changes with the original commits so that you have a cleaner history for your pull requests. |
|
Thanks, I'll see how it works |
|
Change has been merged: 3b36845 Thank you again 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.