Upgrade dependencies, migrate to the official docker client, and make the listening code more robust #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenchzed
changed the title
|
Thanks for the PR, can you fix the errors displayed in the CI workflow please? |
…op more robust to errors
frenchzed
force-pushed
the
upgrade_dependencies
branch
from
669f0b4 to
99940a0
Compare
@aacebedo, it should be ok now (at least I think :P) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few minor bugs at the same time, along with a redesign of the Docker error handling.
Before creating your PR, execute the following command:
$> go vet
$> go lint
$> go fmt
$> go build
$> go test
PR source branches shall have the following name: feature/<PR_NAME>
PR destination branch shall be develop
Any PR not respecting those rules won't be merge and will be closed after a few weeks if not updated.