CONFIG: Update GitHub Actions trigger #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+8
to
+9
| branches: | ||
| - main |
There was a problem hiding this comment.
Do we need this? Probably should only run on tag push, not push to main.
There was a problem hiding this comment.
I was thinking to use the main push for verifying merged commits.
Otherwise, happy to remove it
|
Unrelated - I was looking for existing python setups for GH actions in our org. You should be able to cache pip too. |
Good find! |
ucokzeko
force-pushed
the
config/update-actions
branch
from
6a83118 to
c29bd2c
Compare
zacbrannelly
force-pushed
the
config/update-actions
branch
from
c29bd2c to
4e3ce69
Compare
zacbrannelly
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing this from the previous PR 😀