Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add ton jettons #26

Open
wants to merge 1,260 commits into
base: feat/ton
Choose a base branch
from
Open

Feat/add ton jettons #26

wants to merge 1,260 commits into from

Conversation

emmanuelm41
Copy link
Member

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link
Member Author

@emmanuelm41 emmanuelm41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty solid so far @ayelenmurano!!! It looks great!!

libs/coin-modules/coin-ton/src/cli-transaction.ts Outdated Show resolved Hide resolved
libs/coin-modules/coin-ton/src/js-estimateMaxSpendable.ts Outdated Show resolved Hide resolved
libs/coin-modules/coin-ton/src/js-prepareTransaction.ts Outdated Show resolved Hide resolved
libs/coin-modules/coin-ton/src/js-prepareTransaction.ts Outdated Show resolved Hide resolved
libs/coin-modules/coin-ton/src/js-signOperation.ts Outdated Show resolved Hide resolved
libs/coin-modules/coin-ton/src/js-signOperation.ts Outdated Show resolved Hide resolved
libs/coin-modules/coin-ton/src/utils.ts Outdated Show resolved Hide resolved
libs/coin-modules/coin-ton/src/utils.ts Outdated Show resolved Hide resolved
libs/ledgerjs/packages/cryptoassets/src/data/jetton.json Outdated Show resolved Hide resolved
apps/ledger-live-desktop/cryptoassets.md Outdated Show resolved Hide resolved
@@ -18595,8 +18595,10 @@ var package_default = {
"coin:bitcoin": "pnpm --filter coin-bitcoin",
"coin:evm": "pnpm --filter coin-evm",
"coin:framework": "pnpm --filter coin-framework",
"coin:tester": "pnpm --filter coin-tester",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be unrelated change...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I'll delete it. Thanks for realizing it!

@@ -775,8 +775,9 @@ const envDefinitions = {
parser: intParser,
desc: "Configure the low battery percentage threshold",
},
// TODO: TON switch to mainnet
API_TON_ENDPOINT: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could move this to config.ts like in near https://github.com/LedgerHQ/ledger-live/blob/e7ed028716bccb9dc29aa2fc672ecc7a3e78276a/libs/coin-modules/coin-near/src/config.ts

I think they recently added this way of adding env config variables.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good idea! I hadn't seen it. I'll add the endpoint and key from there.

Copy link
Member

@lawRathod lawRathod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks pretty great to me!! πŸš€

Copy link
Member Author

@emmanuelm41 emmanuelm41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to me too πŸš€

@ayelenmurano ayelenmurano force-pushed the feat/add-ton-jettons branch 2 times, most recently from b4a06ec to 7a1ed78 Compare May 30, 2024 15:22
@ayelenmurano ayelenmurano force-pushed the feat/add-ton-jettons branch 4 times, most recently from af132dc to 3c3a8c5 Compare July 4, 2024 17:42
KVNLS and others added 17 commits July 5, 2024 15:20
feat(lld): refactor of breadcrumb for nft gallery
* fix: LIVE-13279

* feat: stop caching results from fallback + throws correctly when network error

* chore: changeset

* chore: var renaming

* chore: const in caps
* fix: coin-tester polkadot runtime upgrade

* fix: update changelog

* fix: update polkadot nano app firmware version in coin-tester

* fix: lint error
* fix: revert ignoring all swaps error

* chore: changeset
[QAA][Playwright] Fix playwright mocked test for features flags prod
…os_firebase_testing

[QAA-137][Speculos] Change back firebase env to testing
…rbo-2"

This reverts commit ef86807, reversing
changes made to c34461a.
@emmanuelm41 emmanuelm41 force-pushed the feat/add-ton-jettons branch from 01d342f to 5fc15d5 Compare July 22, 2024 15:10
@emmanuelm41 emmanuelm41 force-pushed the feat/add-ton-jettons branch from 96a344b to 3445486 Compare July 22, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.