Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rosetta #3

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Fix Rosetta #3

merged 1 commit into from
Sep 22, 2022

Conversation

rllola
Copy link

@rllola rllola commented Sep 21, 2022

  • Harcode block identifier
  • Fix network status
  • Fix getHeight for nil index
  • Fix pagination for getting all the currencies

🔗 zboto Link

fix missing coma

should work

print block height answer

why index null

should fix getHeight

forgot fmt

fix get account at current height

check rosetta request

misc

misc

misc

misc

misc

misc

misc

misc

infinite loop
accountCoins, err := on.client.Balances(ctx, request.AccountIdentifier.Address, &height)
if err != nil {
return nil, errors.ToRosetta(err)
}

s, _ := json.Marshal(accountCoins)

Check warning

Code scanning / gosec

Returned error is not propagated up the stack.

Returned error is not propagated up the stack.
@raynaudoe raynaudoe merged commit aaad7c1 into main Sep 22, 2022
rllola added a commit that referenced this pull request Sep 28, 2022
fix missing coma

should work

print block height answer

why index null

should fix getHeight

forgot fmt

fix get account at current height

check rosetta request

misc

misc

misc

misc

misc

misc

misc

misc

infinite loop
@rllola rllola deleted the fix/rosetta branch September 28, 2022 13:06
rllola added a commit that referenced this pull request Oct 18, 2022
fix missing coma

should work

print block height answer

why index null

should fix getHeight

forgot fmt

fix get account at current height

check rosetta request

misc

misc

misc

misc

misc

misc

misc

misc

infinite loop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants