Remove tests for deprecated attribute proto_library.proto_source_root #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proto_library.proto_source_root is still broken for external workspaces after bazelbuild/bazel#8683 lands. Since the attribute is deprecated anyway (bazelbuild/bazel#7153), this will not be fixed in Bazel (bazelbuild/bazel#8683 (comment)). This change removes the tests that verify our rules work when targets define proto_library.proto_source_root.
Yannic
pushed a commit
that referenced
this pull request
Jun 24, 2019
…source_root GitOrigin-RevId: ed8be6d0d3c00b8896edc2b768c47cd51b267048
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proto_library.proto_source_root is still broken for external workspaces
after bazelbuild/bazel#8683 lands. Since the
attribute is deprecated anyway
(bazelbuild/bazel#7153), this will not be
fixed in Bazel
(bazelbuild/bazel#8683 (comment)).
This change removes the tests that verify our rules work when targets
define proto_library.proto_source_root.