Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suport new Packer plugin installation #69

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

FalcoSuessgott
Copy link
Collaborator

This PR is based #59 and adds support for the new packer initplugin installation.

I updated the README.md accordingly.

You can test it with my fork:

# packer.pkr.hcl
packer {
  required_version = ">= 1.9.0"

  required_plugins {
    goss = {
      version = "0.0.7"
      source  = "github.com/FalcoSuessgott/goss"
    }
  }
}
$> PACKER_PLUGIN_PATH=_packer-plugins packer init .
Installed plugin github.com/falcosuessgott/goss v0.0.7 in "_packer-plugins/github.com/falcosuessgott/goss/packer-plugin-goss_v0.0.7_x5.0_linux_amd64"
$> tree _packer-plugins 
_packer-plugins
└── github.com
    └── falcosuessgott
        └── goss
            ├── packer-plugin-goss_v0.0.7_x5.0_linux_amd64
            └── packer-plugin-goss_v0.0.7_x5.0_linux_amd64_SHA256SUM

@MadJlzz
Copy link

MadJlzz commented Sep 25, 2023

I tried on my end with the solution of @FalcoSuessgott and I can confirm it works well 🎆

@micxer
Copy link

micxer commented Oct 16, 2023

Any chance this gets merged soon? This really helps a lot!

@btassone btassone merged commit c519e1c into YaleUniversity:master Oct 21, 2023
Copy link
Contributor

@btassone btassone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@FalcoSuessgott
Copy link
Collaborator Author

Thanks for merging! In order to make it available, you would have to tag it. In the README I assumed the next tag would be 3.2.0 :)

@btassone
Copy link
Contributor

Thanks for merging! In order to make it available, you would have to tag it. In the README I assumed the next tag would be 3.2.0 :)

doing this on an ipad while watching Baki so im a touch slow atm 😂. i’ll adjust the tag

@btassone
Copy link
Contributor

Thanks for merging! In order to make it available, you would have to tag it. In the README I assumed the next tag would be 3.2.0 :)

is the other PR from 2021 still relevant btw? @FalcoSuessgott

@FalcoSuessgott
Copy link
Collaborator Author

Hehe no problem mate. AFAIK the other PR aswell as some issues can be closed now. I will comment the issues. :)

@btassone
Copy link
Contributor

Hehe no problem mate. AFAIK the other PR aswell as some issues can be closed now. I will comment the issues. :)

Roger that! I’ll start cleaning up the ones u comment on. Appreciate it!

@F21
Copy link
Contributor

F21 commented Oct 22, 2023

Hey @FalcoSuessgott and @btassone, thanks so much for getting this in. Can the repository be renamed to packer-plugin-goss to support plugin installation?

Packer expects plugin repositories to have the following pattern: github.com/org/packer-plugin-xxxx

Currently, packer init fails because the repository is named YaleUniversity/packer-provisioner-goss:

Failed getting the "github.com/yaleuniversity/goss" plugin:
1 error occurred:
        * GET https://api.github.com/repos/yaleuniversity/packer-plugin-goss/git/matching-refs/tags: 404 Not Found []

The binaries should also be rebuilt, so that the file names are in this format: packer-plugin-goss_vX.Y.Z_x5.0_OS_ARCH.zip

@FalcoSuessgott
Copy link
Collaborator Author

Oh, yeah indeed. I forgot that I renamed my fork to packer-plugin-goss in order to make it work.

@btassone do you have the permissions to rename the repo?

@btassone
Copy link
Contributor

Yep! I'll make that change here shortly. Thanks for the heads up.

@F21
Copy link
Contributor

F21 commented Nov 6, 2023

ping @btassone

@ian-flores
Copy link

Hi folks, we would also benefit from this renaming so if there is anyway we (or I personally) can help land this please post here so we can do so.

@btassone
Copy link
Contributor

btassone commented Nov 6, 2023

@ian-flores @F21 @FalcoSuessgott

Opened up a new pr #70 to continue discussion on this

@btassone
Copy link
Contributor

btassone commented Nov 6, 2023

Just as an update in case folks didn't see in the other PR. You should be all set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants