-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suport new Packer plugin installation #69
Conversation
c1fb07d
to
089407a
Compare
089407a
to
84133ce
Compare
I tried on my end with the solution of @FalcoSuessgott and I can confirm it works well 🎆 |
Any chance this gets merged soon? This really helps a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks for merging! In order to make it available, you would have to tag it. In the README I assumed the next tag would be 3.2.0 :) |
doing this on an ipad while watching Baki so im a touch slow atm 😂. i’ll adjust the tag |
is the other PR from 2021 still relevant btw? @FalcoSuessgott |
Hehe no problem mate. AFAIK the other PR aswell as some issues can be closed now. I will comment the issues. :) |
Roger that! I’ll start cleaning up the ones u comment on. Appreciate it! |
Hey @FalcoSuessgott and @btassone, thanks so much for getting this in. Can the repository be renamed to Packer expects plugin repositories to have the following pattern: Currently,
The binaries should also be rebuilt, so that the file names are in this format: |
Oh, yeah indeed. I forgot that I renamed my fork to @btassone do you have the permissions to rename the repo? |
Yep! I'll make that change here shortly. Thanks for the heads up. |
ping @btassone |
Hi folks, we would also benefit from this renaming so if there is anyway we (or I personally) can help land this please post here so we can do so. |
@ian-flores @F21 @FalcoSuessgott Opened up a new pr #70 to continue discussion on this |
Just as an update in case folks didn't see in the other PR. You should be all set. |
This PR is based #59 and adds support for the new
packer init
plugin installation.I updated the README.md accordingly.
You can test it with my fork: