Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨Add end msg after run process #96

Merged
merged 3 commits into from
Feb 7, 2022
Merged

🎨Add end msg after run process #96

merged 3 commits into from
Feb 7, 2022

Conversation

AdrySky
Copy link
Contributor

@AdrySky AdrySky commented Jan 31, 2022

Description

This will print "Finish Executing" at the end of every run process.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Run any xircuits
    1. Does it print out the msg at the end of the run process?

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

@AdrySky AdrySky added the enhancement New feature or request label Jan 31, 2022
@AdrySky AdrySky requested a review from MFA-X-AI January 31, 2022 04:08
@AdrySky AdrySky self-assigned this Jan 31, 2022
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would work in the shorterm, but will likely break once we have branch component. Perhaps we can add the print in the javascript codegen side?

@AdrySky
Copy link
Contributor Author

AdrySky commented Jan 31, 2022

I don't think it'll break even if we have the branch component. As this will only happen at the 'END' of the components. I don't think a branch component is gonna be the last component.

Though, I might be wrong since we don't have a working branch component yet.

Also, I'm not sure about putting a print statement in the codegen side. Just a personal preference. I could do it if you want.

@MFA-X-AI
Copy link
Member

Also, I'm not sure about putting a print statement in the codegen side. Just a personal preference. I could do it if you want.

Since the BaseComponent should do the bare minimum, I would say it would make sense to put it in the codegen, so that even if there's a component that doesn't inherit from Base Component, Xircuits would be able to state the process is complete.

@AdrySky AdrySky requested a review from MFA-X-AI February 7, 2022 03:08
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works perfectly. Good work!

@MFA-X-AI MFA-X-AI merged commit b0f0954 into master Feb 7, 2022
@MFA-X-AI MFA-X-AI deleted the adry/add-end-msg branch February 7, 2022 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants