-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add Attach - Detach Options to Canvas Context Menu #342
Conversation
@@ -365,6 +366,26 @@ export class CustomPortModel extends DefaultPortModel { | |||
|
|||
} | |||
|
|||
getTargetPorts = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat, these functions could cut down on some of the repetition I've got in the addHover
and removeHover
functions, as well as the ones in the copy & paste support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this one, I've noticed that the selectAllRelevantNodes
also highlights the links, and the addHover - removeHover accesses the properties through their names.
fbf4e5d
to
519f834
Compare
Description
This PR introduces 3 new context menu options, with the following spawn logic:
Literals
are selected.non-parameter components
are selected that has at least one detached Literal connected.non-parameter components
are selected that has at least one attached Literal connected.Pull Request Type
Type of Change
Tests
Attach
a Literal node by right clicking a Literal Node. Verify you can also do this by selecting multiple Literals.Tested on?