Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix literal secret handling in Dynalists #331

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Conversation

treo
Copy link
Contributor

@treo treo commented Jun 12, 2024

Description

Usage of literal secrets failed to compile when used with dynalists because the literal handling for dynalists was missing that case.

To resolve the problem, I've refactored the handling into a single method that is used in every place.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

1. Manual Test

1. Try to compile [secret-dynaport-compile.xircuits.json](https://github.com/user-attachments/files/15800530/secret-dynaport-compile.xircuits.json) 
2. Without the fix it breaks, with the fix it works.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Copy link

Binder 👈 Launch a binder notebook on branch XpressAI/xircuits/paul/fix-secret-literals

@treo treo requested a review from MFA-X-AI June 12, 2024 07:50
@MFA-X-AI MFA-X-AI merged commit e316b65 into master Jun 17, 2024
9 checks passed
@MFA-X-AI MFA-X-AI deleted the paul/fix-secret-literals branch June 17, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants